Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Search Results bugs #1004

Merged
merged 10 commits into from
May 7, 2021
Merged

Fix Search Results bugs #1004

merged 10 commits into from
May 7, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented May 4, 2021 •
edited
Loading

Closes #990
Closes #992

@render
Copy link

render bot commented May 4, 2021

Your Render PR Server URL is https://files-landing-dev-pr-1004.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c28i79u31hs1re75pubg.

@render
Copy link

render bot commented May 4, 2021

Your Render PR Server URL is https://chainsafex-dev-pr-1004.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c28i7a631hs1re75pugg.

@render
Copy link

render bot commented May 4, 2021

Your Render PR Server URL is https://files-ui-dev-pr-1004.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c28i7am31hs1re75pum0.

@FSM1 FSM1 linked an issue May 4, 2021 that may be closed by this pull request
Double clicking on a folder in the search result page doens't do anything #992
Closed
@FSM1 FSM1 requested review from RyRy79261, Tbaut and tanmoyAtb May 4, 2021 10:40
@FSM1 FSM1 self-assigned this May 4, 2021
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label May 4, 2021
@FSM1 FSM1 changed the title Fix Invalid Date in search results Fix Search Results bugs May 4, 2021
@FSM1 FSM1 marked this pull request as ready for review May 4, 2021 10:42
@FSM1 FSM1 added Release: Minor only for PROD release PR Type: Bug Fix Added to PRs if they are addressing a bug labels May 4, 2021
@render
Copy link

render bot commented May 5, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1004.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c29fttm31hscgoaejpkg.

@tanmoyAtb
Copy link
Contributor

Hey @FSM1 the folder nav looks good!
Still need to handle the invalid date.

@FSM1
Copy link
Contributor Author

FSM1 commented May 6, 2021

Hey @FSM1 the folder nav looks good!
Still need to handle the invalid date.

And it's now fixed... got overwritten by the grid changes

tanmoyAtb
tanmoyAtb approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go 👍

@FSM1 FSM1 merged commit 974053c into dev May 7, 2021
@FSM1 FSM1 deleted the fix/invalid-date-in-search-results-990 branch May 7, 2021 10:46
@FSM1 FSM1 mentioned this pull request May 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees

@FSM1 FSM1

Labels
Release: Minor only for PROD release PR Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double clicking on a folder in the search result page doens't do anything Invalid date in the search results
3 participants
@FSM1 @tanmoyAtb @RyRy79261