Add username #1133

tanmoyAtb · 2021-06-14T19:32:54Z

closes #1091

render · 2021-06-14T19:32:56Z

Your Render PR Server URL is https://files-ui-stage-pr-1133.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c33qtps64ckuofh57ss0.

render · 2021-06-14T19:32:59Z

Your Render PR Server URL is https://storage-ui-stage-pr-1133.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c33qtqc64ckuofh57tcg.

…at/add-username-1091

Tbaut

Working well but I'm getting some 404 on https://stage.imploy.site/api/v1/user/lookup when typing something (although the lookup does work).

packages/common-components/src/TextInput/FormikTextInput.tsx

packages/common-components/src/TextInput/TextInput.tsx

packages/files-ui/src/Components/Modules/Settings/Profile.tsx

Tbaut · 2021-06-16T10:53:56Z

packages/files-ui/src/Components/Modules/Settings/Profile.tsx

                    <FormikTextInput
                      placeholder={t`First name`}
                      name="firstName"
                      size="medium"
+                      hideLabel={true}


Didn't check deeper but can't we have empty label rather?

the label is actually optional, but the FormikTextInput passes the field.name and I had no way of removing that since its being used else where in code.

packages/files-ui/src/Components/Modules/Settings/Profile.tsx

packages/files-ui/src/Contexts/UserContext.tsx

packages/files-ui/src/Components/Modules/Settings/Profile.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

CLAassistant · 2021-06-16T18:29:07Z

All committers have signed the CLA.

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

lgtm-com · 2021-06-16T18:35:07Z

This pull request fixes 1 alert when merging d666072 into f1852e9 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

…at/add-username-1091

tanmoyAtb · 2021-06-16T18:59:38Z

Working well but I'm getting some 404 on https://stage.imploy.site/api/v1/user/lookup when typing something (although the lookup does work).

Yes, the lookup api responds with 404 when it doesn't find a username we are sending,
not sure if thats a standard behaviour but it works.

lgtm-com · 2021-06-16T19:03:59Z

This pull request fixes 1 alert when merging 9efa618 into f1852e9 - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

lgtm-com · 2021-06-16T21:20:37Z

This pull request fixes 1 alert when merging 2e4e72f into 2f3d1eb - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class

Tbaut · 2021-06-17T09:23:20Z

api responds with 404 when it doesn't find a username we are sending,
not sure if thats a standard behaviour but it works.

ok a 404 is definitely not a standard for an expected answer, this is showing red things all over (network and console tab), it is handled as an error in the code and in the browser. I guess it should be a 200 with null or something. I'll check with the api team

Tbaut

👍 nice one! Just the cla signing is missing 🤷‍♂️

tanmoyAtb · 2021-06-17T13:43:50Z

api responds with 404 when it doesn't find a username we are sending,
not sure if thats a standard behaviour but it works.

ok a 404 is definitely not a standard for an expected answer, this is showing red things all over (network and console tab), it is handled as an error in the code and in the browser. I guess it should be a 200 with null or something. I'll check with the api team

Yes a 200 with null, sounds right!

tanmoyAtb added 8 commits June 14, 2021 00:10

ui ready

ad65141

adding username functions

46d05d7

wip

8bd15ea

wip

6d3d460

chenging to form

8672701

before lookup problem

1703a30

profile update

81b6a9f

adding username reeady

65f2e8f

github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jun 14, 2021

actions-user and others added 7 commits June 14, 2021 19:37

lingui extract

4198b60

disable email

7eb135d

merged

824e6b6

Merge branch 'feat/add-username-1091' of github.com:imploy/ui into fe…

a2ff275

…at/add-username-1091

removed FB logo

e45463c

changes and comments

d252b39

profile update

a3f0086

tanmoyAtb changed the title ~~add username~~ Add username Jun 15, 2021

tanmoyAtb requested review from Tbaut, FSM1 and RyRy79261 June 15, 2021 16:06

tanmoyAtb marked this pull request as ready for review June 15, 2021 16:06

Merge branch 'dev' of github.com:imploy/ui into feat/add-username-1091

309fdcd

tanmoyAtb added the Status: Review Needed 👀 Added to PRs when they need more review label Jun 15, 2021

Tbaut requested changes Jun 16, 2021

View reviewed changes

Tbaut added Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. and removed Status: Review Needed 👀 Added to PRs when they need more review labels Jun 16, 2021

Update packages/common-components/src/TextInput/FormikTextInput.tsx

967f8d1

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

tanmoyAtb and others added 4 commits June 17, 2021 00:29

Update packages/common-components/src/TextInput/TextInput.tsx

003539f

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

eeec3f3

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Contexts/UserContext.tsx

a971c5f

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

lingui extract

d666072

tanmoyAtb and others added 11 commits June 17, 2021 00:51

Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

53674dd

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Contexts/UserContext.tsx

f7b3530

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Contexts/UserContext.tsx

d435815

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx

a0bdb65

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

Update packages/files-ui/src/Contexts/UserContext.tsx

f2b001a

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

suggested changes

dce13fb

Merge branch 'feat/add-username-1091' of github.com:imploy/ui into fe…

0053e02

…at/add-username-1091

lingui extract

6e91dd2

pushed to 300ms debounce

3997683

Merge branch 'feat/add-username-1091' of github.com:imploy/ui into fe…

dae1f41

…at/add-username-1091

lingui extract

9efa618

tanmoyAtb requested a review from Tbaut June 16, 2021 18:59

FSM1 approved these changes Jun 16, 2021

View reviewed changes

Merge branch 'dev' into feat/add-username-1091

2e4e72f

Tbaut approved these changes Jun 17, 2021

View reviewed changes

Merge branch 'dev' into feat/add-username-1091

45fbe19

tanmoyAtb merged commit 0382ee6 into dev Jun 17, 2021

tanmoyAtb deleted the feat/add-username-1091 branch June 17, 2021 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add username #1133

Add username #1133

tanmoyAtb commented Jun 14, 2021

render bot commented Jun 14, 2021

render bot commented Jun 14, 2021

Tbaut left a comment

Tbaut Jun 16, 2021

tanmoyAtb Jun 16, 2021

CLAassistant commented Jun 16, 2021 •

edited

Loading

lgtm-com bot commented Jun 16, 2021

tanmoyAtb commented Jun 16, 2021

lgtm-com bot commented Jun 16, 2021

lgtm-com bot commented Jun 16, 2021

Tbaut commented Jun 17, 2021 •

edited

Loading

Tbaut left a comment

tanmoyAtb commented Jun 17, 2021

Add username #1133

Add username #1133

Conversation

tanmoyAtb commented Jun 14, 2021

render bot commented Jun 14, 2021

render bot commented Jun 14, 2021

Tbaut left a comment

Choose a reason for hiding this comment

Tbaut Jun 16, 2021

Choose a reason for hiding this comment

tanmoyAtb Jun 16, 2021

Choose a reason for hiding this comment

CLAassistant commented Jun 16, 2021 • edited Loading

lgtm-com bot commented Jun 16, 2021

tanmoyAtb commented Jun 16, 2021

lgtm-com bot commented Jun 16, 2021

lgtm-com bot commented Jun 16, 2021

Tbaut commented Jun 17, 2021 • edited Loading

Tbaut left a comment

Choose a reason for hiding this comment

tanmoyAtb commented Jun 17, 2021

CLAassistant commented Jun 16, 2021 •

edited

Loading

Tbaut commented Jun 17, 2021 •

edited

Loading