Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lgtm alerts #1169

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Fix lgtm alerts #1169

merged 5 commits into from
Jun 29, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 22, 2021

@Tbaut Tbaut requested review from RyRy79261, tanmoyAtb and FSM1 June 22, 2021 13:38
@render
Copy link

render bot commented Jun 22, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1169.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c38ufpj2v8p1mrntk5n0.

@render
Copy link

render bot commented Jun 22, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1169.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c38ufq32v8p1mrntk67g.

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Jun 22, 2021
@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 22, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2021

This pull request fixes 14 alerts when merging 698ad53 into c5c925f - view on LGTM.com

fixed alerts:

  • 8 for Duplicate character in character class
  • 3 for Identical operands
  • 2 for Useless conditional
  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2021

This pull request fixes 14 alerts when merging 6cddef2 into c5c925f - view on LGTM.com

fixed alerts:

  • 8 for Duplicate character in character class
  • 3 for Identical operands
  • 2 for Useless conditional
  • 1 for Useless assignment to local variable

RyRy79261
RyRy79261 reviewed Jun 23, 2021
View reviewed changes
packages/common-theme/src/utils/colorManipulator.ts
valuesArray[2] = `${values[2]}%`
}

export function recomposeColor({ type, values }: IColorObject) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a regression

Copy link
Collaborator Author

@Tbaut Tbaut Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check it out in details, valuesArray is actually never used.

edit: I'm fine to remove this function altogether, I don't think it's used either anyway.

@Tbaut Tbaut requested a review from RyRy79261 June 23, 2021 14:50
@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request fixes 14 alerts when merging 33ab8d7 into d3e6974 - view on LGTM.com

fixed alerts:

  • 8 for Duplicate character in character class
  • 3 for Identical operands
  • 2 for Useless conditional
  • 1 for Useless assignment to local variable

tanmoyAtb
tanmoyAtb approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2021

This pull request fixes 14 alerts when merging 88f3c8f into 83b333d - view on LGTM.com

fixed alerts:

  • 8 for Duplicate character in character class
  • 3 for Identical operands
  • 2 for Useless conditional
  • 1 for Useless assignment to local variable

@Tbaut Tbaut removed the Status: Review Needed 👀 Added to PRs when they need more review label Jun 29, 2021
@Tbaut Tbaut merged commit 20ca44f into dev Jun 29, 2021
@Tbaut Tbaut deleted the fix/tbaut-fix-lgtm-alerts branch June 29, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaut @RyRy79261 @tanmoyAtb