Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow in Storage api keys, buckets and cid pages #1193

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Fix overflow in Storage api keys, buckets and cid pages #1193

merged 3 commits into from
Jun 25, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 24, 2021 •
edited
Loading

closes #1192
closes #1190 while I'm here

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Jun 24, 2021
@render
Copy link

render bot commented Jun 24, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1193.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3a61647o9q6dup7nt30.

@render
Copy link

render bot commented Jun 24, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1193.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3a616k7o9q6dup7ntjg.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 24, 2021
@Tbaut Tbaut changed the title Fix overflow in Storage api keys Fix overflow in Storage api keys, buckets and cid pages Jun 24, 2021
asnaith
asnaith approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just validated the fixes on Render, looking good now 🙂

@Tbaut Tbaut merged commit a3b2ac9 into dev Jun 25, 2021
@Tbaut Tbaut deleted the fix/tbaut-overflow-api-key-1192 branch June 25, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@asnaith asnaith asnaith approved these changes

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
3 participants
@Tbaut @asnaith @FSM1