Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint action for forked repos #1198

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix lint action for forked repos #1198

merged 2 commits into from
Jun 29, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 29, 2021

Lint is failing for #1196 because of this "with" apparently. Also I don't know why this line was useful in the first place, I copy pasted it from an example πŸ€·β€β™‚οΈ What it does is get the branch from the current repo, but this doesn't work for forked repos.

@render
Copy link

render bot commented Jun 29, 2021

@render
Copy link

render bot commented Jun 29, 2021

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 29, 2021
@Tbaut Tbaut added the Status: Review Needed πŸ‘€ Added to PRs when they need more review label Jun 29, 2021
@Tbaut Tbaut requested review from FSM1 and tanmoyAtb June 29, 2021 09:26
@Tbaut Tbaut changed the title Remove with from checkout action Fix lint action for forked repos Jun 29, 2021
@Tbaut Tbaut enabled auto-merge (squash) June 29, 2021 09:33
@Tbaut Tbaut merged commit 1f9b920 into dev Jun 29, 2021
@Tbaut Tbaut deleted the fix/tbaut-unneeded-ref branch June 29, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed πŸ‘€ Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants