-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorted by dates by default #1257
Conversation
Your Render PR Server URL is https://gaming-ui-stage-pr-1257.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3m6qps7o9q7tesh4570. |
Your Render PR Server URL is https://storage-ui-stage-pr-1257.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3m6qq47o9q7tesh45gg. |
Your Render PR Server URL is https://files-ui-stage-pr-1257.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3m6qqk7o9q7tesh45s0. |
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked the UI, there's no sorting in the columns? Could we add it? Otherwise all the logic for the sorting direction etc isn't used.
I did not put the sorting buttons into the column heads, as this was not in the issue scope, |
My main concern is that this PR is a bit in between. Either we just build what the issue wants, and sort things per name in a hard-coded manner, or we copy/paste some older code, but then we make sure it's actually fully used. Right now all these I guess it's a quick win to add the sorting in the header, but I personally wouldn't mind if you go the other route. |
All right, I totally feel you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good 🎉
closes #1215
I kept the states in place, in case we want to have sorting functionality on the table columns in future