Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload progress not working #1318

Merged
merged 2 commits into from
Jul 23, 2021
Merged

upload progress not working #1318

merged 2 commits into from
Jul 23, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jul 23, 2021

Closes #1286

@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Jul 23, 2021
@FSM1 FSM1 requested review from asnaith, RyRy79261 and tanmoyAtb July 23, 2021 09:54
@FSM1 FSM1 self-assigned this Jul 23, 2021
@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1318.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3t93jk7o9qelbmn8en0.

@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1318.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3t93k47o9qelbmn8f0g.

@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1318.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3t93kk7o9qelbmn8fh0.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jul 23, 2021
tanmoyAtb
tanmoyAtb approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, this one gets fixed ! 💯

@FSM1 FSM1 merged commit 00b1f6b into dev Jul 23, 2021
@FSM1 FSM1 deleted the fix/upload-progress-not-working-1286 branch July 23, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload progress only goes from 0 to 1 directly
3 participants
@FSM1 @RyRy79261 @tanmoyAtb