Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FILES] Allow user to delete or remove themselves from a shared folder #1329

Merged
merged 10 commits into from
Jul 27, 2021
Merged

[FILES] Allow user to delete or remove themselves from a shared folder #1329

merged 10 commits into from
Jul 27, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jul 23, 2021

Closes #1303

@FSM1 FSM1 self-assigned this Jul 23, 2021
@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jul 23, 2021
@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1329.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3thpec6fj3adr29213g.

@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1329.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3thpfk6fj3adr2921n0.

@render
Copy link

render bot commented Jul 23, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1329.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c3thpgs6fj3adr2922ig.

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2021

This pull request introduces 2 alerts when merging 1b182be into 8b55baa - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2021

This pull request introduces 2 alerts when merging d7b980a into dc791b2 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@FSM1 FSM1 changed the title Allow user to remove themselves from share [FILES] Allow user to remove themselves from share Jul 27, 2021
@FSM1 FSM1 changed the title [FILES] Allow user to remove themselves from share [FILES] Allow user to delete or remove themselves from a shared folder Jul 27, 2021
@FSM1 FSM1 marked this pull request as ready for review July 27, 2021 12:58
@FSM1 FSM1 requested a review from asnaith July 27, 2021 12:58
@FSM1 FSM1 added Status: Review Needed 👀 Added to PRs when they need more review and removed Epic: Sharing v1 (current users) labels Jul 27, 2021
tanmoyAtb
tanmoyAtb approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 💯 to me!

Tbaut
Tbaut approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly! Only have nits as I saw them, mostly not introduced by you be quick to fix :)

@Tbaut Tbaut removed the Status: Review Needed 👀 Added to PRs when they need more review label Jul 27, 2021
@asnaith
Copy link
Contributor

asnaith commented Jul 27, 2021

Nice! Looking great on Render 👍

FSM1 and others added 2 commits July 27, 2021 22:01
@FSM1 @tanmoyAtb @Tbaut
Apply suggestions from code review
43784c6 
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1
update Leave icon
bb57f91
@FSM1 FSM1 merged commit 994c093 into dev Jul 27, 2021
@FSM1 FSM1 deleted the feat/remove-yourself-from-share-1303 branch July 27, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Tbaut approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Product: Files Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files: Handle Delete Shared Folder for all users
5 participants
@FSM1 @asnaith @tanmoyAtb @Tbaut @actions-user