Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FILES] Improve Manage Bucket label and icon #1367

Merged
merged 3 commits into from
Jul 29, 2021
Merged

[FILES] Improve Manage Bucket label and icon #1367

merged 3 commits into from
Jul 29, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jul 28, 2021

Closes #1349

@render
Copy link

render bot commented Jul 28, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1367.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c40ml7c6fj35u9cph9s0.

@render
Copy link

render bot commented Jul 28, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1367.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c40ml7s6fj35u9cpha70.

@render
Copy link

render bot commented Jul 28, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1367.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c40ml8c6fj35u9cphajg.

@FSM1 FSM1 self-assigned this Jul 28, 2021
@FSM1 FSM1 requested a review from Tbaut July 28, 2021 14:33
@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jul 28, 2021
@FSM1 FSM1 requested review from RyRy79261 and tanmoyAtb July 28, 2021 14:33
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Jul 28, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2021

This pull request introduces 1 alert when merging 62f5ab5 into 38febc0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@asnaith
Copy link
Contributor

asnaith commented Jul 28, 2021

Looking good! Makes a lot more sense than "Edit".

I noticed that the display order is different from Cindy's mock up (it was the first menu option in the design mock but we are showing it 2nd atm, just thought I'd mention it).

Screen Shot 2021-07-28 at 2 04 26 PM

@Tbaut
Copy link
Collaborator

Tbaut commented Jul 29, 2021 •
edited
Loading

For some reason the linting is never performed for lingui commits. It should have failed and tell the same as the lgtm bot. I checked it out but wasn't able to figure out why. I'll ask for help to some devops

edit: it did fail for the first commit. I figured it out and fixed #1375

@Tbaut Tbaut merged commit b5c841d into dev Jul 29, 2021
@Tbaut Tbaut deleted the fix/manage-shared-folder-access-1349 branch July 29, 2021 09:32
@Tbaut Tbaut mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@Tbaut Tbaut Tbaut approved these changes

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the edit icon for shared folder permission edition
4 participants
@FSM1 @asnaith @Tbaut @actions-user