Programmatic folder creation for tests

[Tbaut]

closes #1410

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-1430.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4951rs6fj33r8n5t2rg.

[render]

Your Render PR Server URL is https://gaming-ui-stage-pr-1430.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4951sc6fj33r8n5t3k0.

[render]

Your Render PR Server URL is https://gaming-ui-stage-pr-1430-kemy.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4951sc6fj33r8n5t3kg.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-1430.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4951ss6fj33r8n5t5jg.

[asnaith]

This is going to be great, thank you for doing this 😃

This is very useful and efficient to use in the scenarios when we need a folder as a requisite for a test but are not testing the folder creation directly.

[asnaith]

I was just experimenting with this new functionality and found a few issues -

1. If you use apiTestHelper.createFolder more than once in a test then only the first folder is created

2. Sometimes a folder is there when the next test starts, it seems like the clearing does not always work now

3. Sometimes a folder is not created at all

Perhaps for reliability the api test helper should confirm the intended creation / deletion was completed before exiting?

I was using this custom test to check the new command:

Cypress._.times(100, () => {
      it.only("Folder creation", () => {
        cy.web3Login({ clearCSFBucket: true, clearTrashBucket: true })

        apiTestHelper.createFolder("/test folder 1/subfolderA")
        homePage.fileItemRow().should("have.length", 1)
        apiTestHelper.createFolder("/test folder 2/subfolderB")
        homePage.fileItemRow().should("have.length", 2)
        apiTestHelper.createFolder("/test folder 3/subfolderC")
        homePage.fileItemRow().should("have.length", 3)
      })
    })

[Tbaut]

@asnaith feel free to check my 5841a94 commit. I've tried to do the check after the folder elegantly, but it basically fails because of other things. I really think we need to get this flow together, I've added logs and when running the test we can see that they are fired in an order that doesn't work at all.

[asnaith]

@Tbaut It's looking good in code but I can't get it to run successfully

Seeing this error which seems to come after trying to clear the bucket

also this when trying to assert on the folder name

I can look into it more tomorrow

[lgtm-com]

This pull request introduces 2 alerts when merging 2268162 into 51808aa - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

[Tbaut]

I managed to beat the monster. The trick is: use new Cypress.Promise. This makes sure that Cypress will wait for us to call the associated resolve before continuing. This way, we can actually do our calls the way we want. The logs that I left in the helper function show that everything is happening in the correct order, which wasn't the case before and was the origin of the race conditions we had.

[asnaith]

This is fantastic, tried it out and it's working great! 🥳

The whole test suite is going to be more efficient and reliable with this in place. Thank you 🙏