Disabled select on row names & enhance simple click experience

[RyRy79261]

closes #1415

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-1438.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a4o21t9dsarmtl7aj0.

[render]

Your Render PR Server URL is https://gaming-ui-stage-pr-1438.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a4o2ht9dsarmtl7avg.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-1438.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a4o31t9dsarmtl7b90.

[Tbaut]

The problem with the selection is fixed perfectly, however with 150ms, this makes the double click way too quick, I barely manage to have a double click now, and the single click is still too slow.

I thought we could change our approach completely and use something like https://stackoverflow.com/a/66515641

We don't really care if the single click event is fired because it's only a selection, so if there's a double click, then it'll select and navigate/show preview.

What do you think?

[RyRy79261]

Ahh ok, 150 was just the number that fit the people I tried it out on, nice find on that example there, I'll test it out n refactor if feasible

[RyRy79261]

@Tbaut So the one issue I think we might run into is using the switch case, that it would trigger single click & double click actions

One option if this becomes an issue is to trigger the execution, alternatively being able to cancel the single click action if double is triggered

[Tbaut]

switch case, that it would trigger single click & double click actions

Yup, this is the behavior I meant to address with my

We don't really care if the single click event is fired because it's only a selection, so if there's a double click, then it'll select and navigate/show preview.

So I don't think it's actually a problem, but we should check how it behaves in real life to be certain it's really not an issue..

[RyRy79261]

Ahh ok rad, yeah just thinking of use beyond our row selection but granted use cases where theres a single and a double tied to the same item are usually select or execute behaviours

[Tbaut]

I think it's a great UX improvement for the simple click, and the double click just works fine from my tests 🎉

[RyRy79261]

Rad! Thanks for the nifty approach, didn't realise events have context of other events

[asnaith]

This is a nice improvement Ryan, the single click feels way better now 😃

[Tbaut]

Can you please check the tests @RyRy79261 one seems to fail for valid reasons 🤷‍♂️

| 1) File management
| desktop
| can delete and recover a folder:
|
| AssertionError: Timed out retrying after 20000ms: Too many elements found. Found '2', expected '1'.
| + expected - actual
|
| -2
| +1

[tanmoyAtb]

OMG! this is a gem! 💎
The events had the info all along!
How come the internet's full of these hook implementations!!!!

[RyRy79261]

@Tbaut Found this magic trick 🔥

I can't believe I only found this out now 😂

[Tbaut]

Lol it's new for all of us, I didn't know either! Just I saw that Dropbox def. didn't have any timeout because their experience was great, and found that thing on wonderful SO :D

[asnaith]

Can you please check the tests @RyRy79261 one seems to fail for valid reasons 🤷‍♂️

| 1) File management
| desktop
| can delete and recover a folder:
|
| AssertionError: Timed out retrying after 20000ms: Too many elements found. Found '2', expected '1'.
| + expected - actual
|
| -2
| +1

@Tbaut @RyRy79261 I took a quick look at this. It's a genuine failure but looks unrelated to Ryan's change. Files that shouldn't be there are present so when asserting that only the recovered folder exists it will fail because it sees other files.

The additional files that can be seen on the screenshot were not added during the test and the test begins with cy.web3Login({ clearCSFBucket: true, clearTrashBucket: true }) which should clear any pre-existing data. I can only assume the API call, to delete pre-existing files prior to the test beginning, did not work.

[Tbaut]

Thanks @asnaith, then let's merge and create an issue for that.

edit: done #1448