Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define modals in the test suite as separate objects #1439

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Define modals in the test suite as separate objects #1439

merged 2 commits into from
Aug 17, 2021

Conversation

asnaith
Copy link
Contributor

@asnaith asnaith commented Aug 11, 2021

closes #1436

@asnaith asnaith requested review from RyRy79261, FSM1 and Tbaut August 11, 2021 22:36
@render
Copy link

render bot commented Aug 11, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1439.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a51s9t9dsarmtl7s40.

@render
Copy link

render bot commented Aug 11, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1439.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a51spt9dsarmtl7sgg.

@render
Copy link

render bot commented Aug 11, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1439.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c4a51t1t9dsarmtl7sqg.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 11, 2021
asnaith
asnaith commented Aug 11, 2021
View reviewed changes
packages/files-ui/cypress/support/page-objects/homePage.ts
@@ -1,20 +1,16 @@
import { basePage } from "./basePage"
import { folderName } from "../../fixtures/filesTestData"

export const click = ($el: JQuery<HTMLElement>) => $el.trigger("click")
Copy link
Contributor Author

@asnaith asnaith Aug 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleaning up. This was not being used anymore since safeClick was added (it's defined in commands.ts).

Tbaut
Tbaut approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good thanks!

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 16, 2021
@asnaith asnaith requested a review from tanmoyAtb August 16, 2021 19:46
@Tbaut Tbaut enabled auto-merge (squash) August 17, 2021 14:14
@Tbaut Tbaut merged commit 05d9d7f into dev Aug 17, 2021
@Tbaut Tbaut deleted the mnt/modal-object-refactor-1436 branch August 17, 2021 14:18
@FSM1 FSM1 mentioned this pull request Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor modals being used in the test suite
3 participants
@asnaith @RyRy79261 @Tbaut