-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FILES] enforce maximum 32 char limit #1464
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-1464.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4frfo4objd9om6g46ag. |
Your Render PR Server URL is https://gaming-ui-stage-pr-1464.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4frfokobjd9om6g46n0. |
Your Render PR Server URL is https://files-ui-stage-pr-1464.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4frfp4objd9om6g470g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from the code
Render's not happy for some reason, I triggered a rebuild
Looks like its passed now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an edge case while playing with it, I realized that when you hit 32 char, the error is displayed very briefly, but is then overridden by a valid state. How to reproduce, type 30 char, and then the last 2 quickly. If just just type the 32nd it's showing an error, but if you type quickly the 31st and 32nd, then it displays that it's fine.
edit: I think it doesn't matter much, maybe an issue with the debounce.
debounce.mp4
ahh yeah that is definitely the debounce 🙈 Might actually try and spend a bit of time optimizing this code. Its a bit convoluted at the moment. |
Closes #1443