Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FILES] enforce maximum 32 char limit #1464

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Aug 20, 2021

Closes #1443

@render
Copy link

render bot commented Aug 20, 2021

@render
Copy link

render bot commented Aug 20, 2021

@render
Copy link

render bot commented Aug 20, 2021

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Aug 20, 2021
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 20, 2021
@FSM1 FSM1 requested review from Tbaut and RyRy79261 August 20, 2021 14:13
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from the code

Render's not happy for some reason, I triggered a rebuild

@FSM1
Copy link
Contributor Author

FSM1 commented Aug 20, 2021

looks good from the code

Render's not happy for some reason, I triggered a rebuild

Looks like its passed now :)

@FSM1 FSM1 merged commit 6005016 into dev Aug 20, 2021
@FSM1 FSM1 deleted the fix/username-length-validation-1443 branch August 20, 2021 16:47
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an edge case while playing with it, I realized that when you hit 32 char, the error is displayed very briefly, but is then overridden by a valid state. How to reproduce, type 30 char, and then the last 2 quickly. If just just type the 32nd it's showing an error, but if you type quickly the 31st and 32nd, then it displays that it's fine.

edit: I think it doesn't matter much, maybe an issue with the debounce.

debounce.mp4

@FSM1
Copy link
Contributor Author

FSM1 commented Aug 20, 2021

Found an edge case while playing with it, I realized that when you hit 32 char, the error is displayed very briefly, but is then overridden by a valid state. How to reproduce, type 30 char, and then the last 2 quickly. If just just type the 32nd it's showing an error, but if you type quickly the 31st and 32nd, then it displays that it's fine.

edit: I think it doesn't matter much, maybe an issue with the debounce.

debounce.mp4

ahh yeah that is definitely the debounce 🙈 Might actually try and spend a bit of time optimizing this code. Its a bit convoluted at the moment.

@FSM1 FSM1 mentioned this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate the amount of characters before submitting a username
4 participants