-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Files] - Billing history #1492
Conversation
* Copy features added, overflow issue still present * Swapped to button * lingui extract * Updated button * lingui extract * Apply suggestions from code review Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Fixed size * lingui extract * minmax * lingui extract * revert unrelated changes * lingui extract * Apply suggestions from code review Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> Co-authored-by: Thibaut Sardan <github@thib.top>
* formik submit not firing * fix mobile * lingui extract * Update packages/storage-ui/src/Components/Modules/FileSystemItem/FileSystemTableItem.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * make eslint :) Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Currently translated at 100.0% (262 of 262 strings) Translation: ChainSafe Files/Chainsafe Files user interface Translate-URL: https://hosted.weblate.org/projects/chainsafe-files/chainsafe-files-user-interface/fr/ Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
* refactor modal * steps logic * image centered * lingui extract * lingui extract * typo * refactor with hook, change icon, ad to share menu * nits * fix storage building Co-authored-by: GitHub Actions <actions@github.com>
* using long press * dragg preview problems * typos * events almost ready * resets * long press options * long press updates * formats * dark mode colors * added hover with breakpoints * lingui extract * Apply suggestions from code review Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * curly spacing * borders * clicks proper placement * reverted linting * removed preview on mobile Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com>
Your Render PR Server URL is https://storage-ui-stage-pr-1492.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4p2bmkobjddd9d9qkf0. |
Your Render PR Server URL is https://gaming-ui-stage-pr-1492.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4p2bn4objddd9d9qkrg. |
Your Render PR Server URL is https://files-ui-stage-pr-1492.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4p2bnkobjddd9d9ql70. |
…e/ui-monorepo into feat/tbaut-billing-history-1458
Your Render PR Server URL is https://files-billing-stage-pr-1492.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4saai41nok4ouih2kq0. |
… into feat/tbaut-billing-history-1458
This pull request introduces 1 alert when merging efda913 into c6e935b - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes on UI -
- I would like the loading to show up in the middle.
- When there are no invoices we should show "No invoices"
- Got this warning because the loading is under
tbody
I didn't get any invoices back with the subscription_id
in the comment. maybe the API
does a mapping with user_id when returning invoices. !
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…e/ui-monorepo into feat/tbaut-billing-history-1458
Ah that's annoying, could you check what subscription id you have and ask Arun to add some invoices to you? The rest should be addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @tanmoyAtb, I added some padding. |
closes #1458
use the following subscription id to see some billing history: 3344e538-e101-4008-83a2-a5477e6c73ca
e.g comment out the first
useEffect
inBillingHistory.tsx
and set the initial state to beconst [subscriptionId, setSubscriptionId] = useState("3344e538-e101-4008-83a2-a5477e6c73ca")