Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] - Billing history #1492

Merged
merged 28 commits into from
Nov 4, 2021
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Sep 3, 2021

closes #1458

use the following subscription id to see some billing history: 3344e538-e101-4008-83a2-a5477e6c73ca

e.g comment out the first useEffect in BillingHistory.tsx and set the initial state to be const [subscriptionId, setSubscriptionId] = useState("3344e538-e101-4008-83a2-a5477e6c73ca")

RyRy79261 and others added 10 commits August 25, 2021 14:02
* Copy features added, overflow issue still present

* Swapped to button

* lingui extract

* Updated button

* lingui extract

* Apply suggestions from code review

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

* Fixed size

* lingui extract

* minmax

* lingui extract

* revert unrelated changes

* lingui extract

* Apply suggestions from code review

Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <github@thib.top>
* formik submit not firing

* fix mobile

* lingui extract

* Update packages/storage-ui/src/Components/Modules/FileSystemItem/FileSystemTableItem.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

* make eslint :)

Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Currently translated at 100.0% (262 of 262 strings)

Translation: ChainSafe Files/Chainsafe Files user interface
Translate-URL: https://hosted.weblate.org/projects/chainsafe-files/chainsafe-files-user-interface/fr/

Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
* refactor modal

* steps logic

* image centered

* lingui extract

* lingui extract

* typo

* refactor with hook, change icon, ad to share menu

* nits

* fix storage building

Co-authored-by: GitHub Actions <actions@github.com>
* using long press

* dragg preview problems

* typos

* events almost ready

* resets

* long press options

* long press updates

* formats

* dark mode colors

* added hover with breakpoints

* lingui extract

* Apply suggestions from code review

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

* curly spacing

* borders

* clicks proper placement

* reverted linting

* removed preview on mobile

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com>
@render
Copy link

render bot commented Sep 3, 2021

@render
Copy link

render bot commented Sep 3, 2021

@render
Copy link

render bot commented Sep 3, 2021

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Sep 3, 2021
@Tbaut Tbaut changed the base branch from dev to epic/tbaut-merge-dev September 3, 2021 13:40
@Tbaut Tbaut changed the title Billing history [Files] - Billing history Sep 3, 2021
Base automatically changed from epic/tbaut-merge-dev to epic/files-billing September 6, 2021 13:25
@render
Copy link

render bot commented Sep 8, 2021

@Tbaut Tbaut changed the base branch from epic/files-billing to mnt/tbaut-merge-dev September 8, 2021 12:05
Base automatically changed from mnt/tbaut-merge-dev to epic/files-billing September 8, 2021 13:33
@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2021

This pull request introduces 1 alert when merging efda913 into c6e935b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Tbaut Tbaut requested review from tanmoyAtb, FSM1, RyRy79261 and asnaith and removed request for tanmoyAtb October 26, 2021 15:14
@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Oct 26, 2021
@Tbaut Tbaut marked this pull request as ready for review October 26, 2021 15:14
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on UI -

  • I would like the loading to show up in the middle.
  • When there are no invoices we should show "No invoices"
  • Got this warning because the loading is under tbody

Screenshot 2021-10-26 at 11 47 49 PM

I didn't get any invoices back with the subscription_id in the comment. maybe the API
does a mapping with user_id when returning invoices. !

packages/files-ui/src/Components/Pages/BillingHistory.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Pages/BillingHistory.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Pages/BillingHistory.tsx Outdated Show resolved Hide resolved
Tbaut and others added 3 commits October 27, 2021 18:29
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…e/ui-monorepo into feat/tbaut-billing-history-1458
@Tbaut
Copy link
Collaborator Author

Tbaut commented Oct 27, 2021

I didn't get any invoices back with the subscription_id in the comment. maybe the API
does a mapping with user_id when returning invoices. !

Ah that's annoying, could you check what subscription id you have and ask Arun to add some invoices to you?

The rest should be addresses.

@Tbaut Tbaut requested a review from tanmoyAtb October 27, 2021 17:31
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go 👍

The mobile view could get some adjustments, with the top padding and table cells.
Screenshot 2021-11-04 at 12 14 22 AM

@Tbaut
Copy link
Collaborator Author

Tbaut commented Nov 4, 2021

Good point @tanmoyAtb, I added some padding.
The receipt will change. It'll just be a link

@Tbaut Tbaut merged commit 7aaf835 into epic/files-billing Nov 4, 2021
@Tbaut Tbaut deleted the feat/tbaut-billing-history-1458 branch November 4, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Billing history
7 participants