-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change plan widget #1649
Change plan widget #1649
Conversation
Your Render PR Server URL is https://gaming-ui-stage-pr-1649.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5om1grru51mu5poj30g. |
Your Render PR Server URL is https://storage-ui-stage-pr-1649.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5om1hbru51mu5poj3a0. |
Your Render PR Server URL is https://files-ui-stage-pr-1649.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5om1hrru51mu5poj3q0. |
This pull request introduces 3 alerts when merging 4cb1bd9 into c6e935b - view on LGTM.com new alerts:
|
Your Render PR Server URL is https://files-billing-stage-pr-1649.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5r7bqjru51uofn4vhig. |
This pull request introduces 3 alerts when merging 150aa31 into c6e935b - view on LGTM.com new alerts:
|
* Fix build for node 17 * lingui extract Co-authored-by: GitHub Actions <actions@github.com> (cherry picked from commit 226254c)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good,
Although the API keeps throwing 500 at me, couldn't test everything.
The loaders looks too big for my liking. could make them smaller.
The mobile view also looks cramped. Not sure if we have designs for them.
Left a few comments.
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductViews/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductModal.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments on the UI, will dig in the code later.
- "current" is hard to read because of the contrast
- "not sure what to pick" font should prob. be bigger
- "Free" disappears when we toggle the annual plan
- button toggle doesn't tell whether or not it's activated. Should it be green then?
- when you select another plan than yours, you can't select the free plan any more, it's disabled. I'd let users actually select it (and disable the apply button)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One flow that has not yet been catered for is if a user attempts to upgrade their subscription but does not have a card added to their account yet.
|
… into feat/change-plan-1455
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the code, the "Free" flashing when we change the yearly/monthly toggle isn't a big deal I guess. Regarding the color, the "Current" plan is super hard to read in light mode with black on blue. We should have white on blue
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductViews/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductModal.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductModal.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductViews/SelectPlan.tsx
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductViews/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/Products/ChangeProductModal.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/CurrentProduct.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/CurrentProduct.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…ngeProductViews/SelectPlan.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…ngeProductModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
… into feat/change-plan-1455
…ngeProductModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…ngeProductModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
as per my previous comment #1649 (comment)
Type casting should be last resort, I'm pretty sure we can be safer than this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comment
@Tbaut The button can only be executed if the value is not undefined, I've added a redundant check to remove the casting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
closes #1455