-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notifications for billing #1656
Conversation
Your Render PR Server URL is https://files-billing-stage-pr-1656.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c5rflvbru51uofn5h7d0. |
This pull request introduces 1 alert when merging 58e486d into c6e935b - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 57e5ae9 into c6e935b - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look pretty good. Just a couple nits. Also we should have some max height and scroll bar
Also how should this look like on Mobile @serenaho and @sweetpea22
packages/files-ui/src/Components/Elements/NotificationsDropdown.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Elements/NotificationsDropdown.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Elements/NotificationsDropdown.tsx
Outdated
Show resolved
Hide resolved
…n.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
This pull request introduces 1 alert when merging 2133e1b into c6e935b - view on LGTM.com new alerts:
|
The notification will replace the search icon let me pull up the design brb! |
Thanks for the feedbacks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's just not push with those fixture notifications :)
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
closes #1646
Edit this in
AppHeader.tsx
to see some notifications.Note: Notifications button don't actually resemble the designs, the designs have the new design of buttons and UI elements which we have to work on.