Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place user dropdown in app nav #1685

Merged
merged 19 commits into from
Nov 5, 2021
Merged

Place user dropdown in app nav #1685

merged 19 commits into from
Nov 5, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #1647

@render
Copy link

render bot commented Oct 29, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1685.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c5u36s3ru51ghntcfem0.

@render
Copy link

render bot commented Oct 29, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1685.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c5u36srru51ghntcfevg.

@render
Copy link

render bot commented Oct 29, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1685.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c5u36tjru51ghntcffc0.

@tanmoyAtb tanmoyAtb changed the base branch from dev to feat/notifications-1646 October 29, 2021 17:46
@tanmoyAtb tanmoyAtb requested review from RyRy79261, FSM1 and Tbaut October 29, 2021 17:48
@tanmoyAtb tanmoyAtb added Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature. and removed Type: Feature Added to PRs to identify that the change is a new feature. labels Oct 29, 2021
@tanmoyAtb tanmoyAtb marked this pull request as ready for review November 1, 2021 12:14
tanmoyAtb and others added 2 commits November 1, 2021 18:16
@tanmoyAtb @Tbaut
Update packages/files-ui/src/Components/Elements/NotificationsDropdow…
d0871b2 
…n.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@tanmoyAtb @Tbaut
Update packages/common-components/src/MenuDropdown/MenuDropdown.tsx
bf93f81 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Tbaut
Tbaut requested changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the username be bigger? Also can we use the identicon library we were talking about, I believe it's this one https://github.com/emeraldpay/hashicon

@tanmoyAtb
Copy link
Contributor Author

Can the username be bigger? Also can we use the identicon library we were talking about, I believe it's this one https://github.com/emeraldpay/hashicon

Made the updates, Hashicon added, made some style updates

tanmoyAtb and others added 2 commits November 3, 2021 00:53
@tanmoyAtb @Tbaut
Update packages/files-ui/src/Components/Layouts/AppHeader.tsx
e0ca2be 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@tanmoyAtb
Merge branch 'feat/notifications-1646' of github.com:ChainSafe/ui-mon…
b912753 
…orepo into feat/user-dropdown-move-1647
@RyRy79261 RyRy79261 requested a review from Tbaut November 3, 2021 10:16
Base automatically changed from feat/notifications-1646 to epic/files-billing November 3, 2021 13:21
@render
Copy link

render bot commented Nov 3, 2021

Your Render PR Server URL is https://files-billing-stage-pr-1685.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c619vqjru51u80tqusjg.

@Tbaut
Copy link
Collaborator

Tbaut commented Nov 4, 2021 •
edited
Loading

Hey @tanmoyAtb, it looks great, just the dropdown isn't properly centered I figured, there's a padding on the section
image

Tbaut
Tbaut approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once this horizontal padding is removed.

@Tbaut Tbaut removed the Status: Review Needed 👀 Added to PRs when they need more review label Nov 4, 2021
@Tbaut Tbaut changed the base branch from epic/files-billing to dev November 4, 2021 13:12
@Tbaut Tbaut changed the base branch from dev to epic/files-billing November 4, 2021 13:20
@tanmoyAtb tanmoyAtb merged commit da47f1d into epic/files-billing Nov 5, 2021
@tanmoyAtb tanmoyAtb deleted the feat/user-dropdown-move-1647 branch November 5, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@FSM1 FSM1 FSM1 approved these changes

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Dropdown restyle
4 participants
@tanmoyAtb @Tbaut @RyRy79261 @FSM1