Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui test coverage for link creation / deletion #1775

Merged
merged 8 commits into from
Nov 26, 2021
Merged

Add ui test coverage for link creation / deletion #1775

merged 8 commits into from
Nov 26, 2021

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Nov 24, 2021

closes #1770

@render
Copy link

render bot commented Nov 24, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1775.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6esf9rru51pch0qekug.

@render
Copy link

render bot commented Nov 24, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1775.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6esfabru51pch0qelb0.

@render
Copy link

render bot commented Nov 24, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1775.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6esfarru51pch0qelsg.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Nov 24, 2021
@asnaith asnaith added the Status: Do Not Merge 🛑 Added to PRs that are not allowed to be merged. label Nov 25, 2021
@asnaith
Copy link
Member Author

asnaith commented Nov 25, 2021 •
edited
Loading

I'm still trying to get confidence in the reliability of this so going to hold off merging for now. It's ok when ran a few times but I have exposed issues with it when running repeatedly.

Even with uncaught exceptions being turned off I'm still seeing some detached from dom / hidden element problems. Going to spend some more time on this.

@asnaith asnaith removed the Status: Do Not Merge 🛑 Added to PRs that are not allowed to be merged. label Nov 26, 2021
@asnaith
Copy link
Member Author

asnaith commented Nov 26, 2021

Looking good now 🙌

@asnaith asnaith merged commit d4b978e into dev Nov 26, 2021
@asnaith asnaith deleted the mnt/share-link-creation-tests-1770 branch November 26, 2021 00:02
@FSM1 FSM1 mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@FSM1 FSM1 FSM1 approved these changes

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui test coverage for share link creation
4 participants
@asnaith @RyRy79261 @tanmoyAtb @FSM1