Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit PR template #1798

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Edit PR template #1798

merged 2 commits into from
Dec 2, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 2, 2021

Some small modifications/suggestions.

  • I think the checkbox should be unchecked by default.
  • I don't see the value in having a checkbox for a title, changed them for a title
  • Placed the comment as comment, so that it doesn't appear in the PR
  • I removed the first part because I think that it's self explanatory. This checkbox will not prevent me from making mistakes and pushing a commit that's breaking things. No-one wants to have a broken PR 🤷‍♂️

@render
Copy link

render bot commented Dec 2, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1798.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6kamn9g7hpfa6e8u4c0.

@Tbaut Tbaut requested a review from asnaith December 2, 2021 11:17
@render
Copy link

render bot commented Dec 2, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1798.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6kamnpg7hpfa6e8u4og.

@Tbaut Tbaut requested review from FSM1 and tanmoyAtb December 2, 2021 11:17
@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Dec 2, 2021
@Tbaut Tbaut merged commit f8e65e3 into dev Dec 2, 2021
@Tbaut Tbaut deleted the mnt/tbaut-template branch December 2, 2021 13:46
@asnaith
Copy link
Member

asnaith commented Dec 2, 2021

Makes sense, thanks for the adjustments

@FSM1 FSM1 mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tbaut @asnaith @tanmoyAtb @FSM1