Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt fixing storybook build #1801

Merged
merged 5 commits into from
Dec 3, 2021
Merged

attempt fixing storybook build #1801

merged 5 commits into from
Dec 3, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Dec 2, 2021

Add the --openssl-legacy-provider flag to ensure compatibility with Node 17

@render
Copy link

render bot commented Dec 2, 2021

@render
Copy link

render bot commented Dec 2, 2021

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Dec 2, 2021
@render
Copy link

render bot commented Dec 2, 2021

@FSM1 FSM1 closed this Dec 2, 2021
@FSM1 FSM1 reopened this Dec 2, 2021
@render
Copy link

render bot commented Dec 2, 2021

@render
Copy link

render bot commented Dec 2, 2021

@render
Copy link

render bot commented Dec 2, 2021

@FSM1 FSM1 self-assigned this Dec 2, 2021
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following, any clue why? I'm on node 16

$ (export NODE_OPTIONS=--openssl-legacy-provider; build-storybook)
 | /home/user/.nvm/versions/node/v16.5.0/bin/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
 | `yarn build:storybook` failed with exit code 9
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 3, 2021
@FSM1
Copy link
Contributor Author

FSM1 commented Dec 3, 2021

I get the following, any clue why? I'm on node 16

$ (export NODE_OPTIONS=--openssl-legacy-provider; build-storybook)
 | /home/user/.nvm/versions/node/v16.5.0/bin/node: --openssl-legacy-provider is not allowed in NODE_OPTIONS
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
 | `yarn build:storybook` failed with exit code 9
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This flag was only added in Node 17, so makes sense that it isn't working here.

(Un)fortunately since Render is using 17, the only way we are going to get this to build on Render is with this flag enabled.

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I guess I'll upgrade then if I need it :)

@Tbaut Tbaut merged commit 9f9e397 into dev Dec 3, 2021
@Tbaut Tbaut deleted the mnt/storybook-fix branch December 3, 2021 15:37
@FSM1 FSM1 mentioned this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants