Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce props on a new line for multiline components #1807

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Enforce props on a new line for multiline components #1807

merged 5 commits into from
Dec 8, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 6, 2021

If this conflicts with you PR, the easy way to fix it is:

  • fix conflicts by accepting only your local changes, effectively ignoring incoming changes.
  • run yarn lint --fix to apply the changes on your branch

@render
Copy link

render bot commented Dec 6, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1807.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6n2irv6d9ktgiitikc0.

@render
Copy link

render bot commented Dec 6, 2021

Your Render PR Server URL is https://chainsafe-components-stage-pr-1807.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6n2isn6d9ktgiitikog.

@render
Copy link

render bot commented Dec 6, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1807.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6n2isv6d9ktgiitikt0.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Dec 6, 2021
@Tbaut Tbaut added Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. and removed Type: Bug Fix Added to PRs if they are addressing a bug labels Dec 6, 2021
tanmoyAtb
tanmoyAtb approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was much needed! 💯

@Tbaut Tbaut merged commit e3778cf into dev Dec 8, 2021
@Tbaut Tbaut deleted the fix/tbaut-eslint-props-new-line branch December 8, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tbaut @tanmoyAtb @FSM1 @actions-user