Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Norwegian translation file #1826

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Cleanup Norwegian translation file #1826

merged 2 commits into from
Dec 13, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 10, 2021

I'm not quite fluent, but this doesn't look very Norwegian :)

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 10, 2021
@render
Copy link

render bot commented Dec 10, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1826.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6pnf1h0gd042roo41k0.

@render
Copy link

render bot commented Dec 10, 2021

Your Render PR Server URL is https://chainsafe-components-stage-pr-1826.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6pnf210gd042roo420g.

@render
Copy link

render bot commented Dec 10, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1826.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6pnf2h0gd042roo4250.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Dec 10, 2021
FSM1
FSM1 previously requested changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 actual translations seem to have gotten caught in the crossfire 😅

@asnaith
Copy link
Member

asnaith commented Dec 13, 2021

2 actual translations seem to have gotten caught in the crossfire 😅

Good catches there @FSM1.

It made me think - would it be worth us adding a couple of rules to the linter "HEAD<<<<<<<" text etc?

@Tbaut @FSM1
Apply suggestions from code review
da49789 
Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com>
@Tbaut
Copy link
Collaborator Author

Tbaut commented Dec 13, 2021

would it be worth us adding a couple of rules to the linter "HEAD<<<<<<<" text etc?

I think it's overkill. These were mistakes from big conflicts with the previous billing branch. Also I'm not sure how to actually ask the linter about these.

@Tbaut Tbaut requested a review from FSM1 December 13, 2021 17:47
@Tbaut Tbaut enabled auto-merge (squash) December 13, 2021 18:01
@Tbaut Tbaut merged commit b1e4cfd into dev Dec 13, 2021
@Tbaut Tbaut deleted the mnt/tbaut-cleanup-trans branch December 13, 2021 18:02
@asnaith
Copy link
Member

asnaith commented Dec 13, 2021

would it be worth us adding a couple of rules to the linter "HEAD<<<<<<<" text etc?

I think it's overkill. These were mistakes from big conflicts with the previous billing branch. Also I'm not sure how to actually ask the linter about these.

@Tbaut Okay cool, just thought I'd throw the idea out there 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tbaut @asnaith @FSM1