Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize element identifier pattern in ui tests #1827

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Dec 14, 2021

closes #1795


Some housekeeping for the element identifiers. I have been prefixing them with the element type (but not initially) and we had a bit of a mixture in use, just a small update to make them all follow the same convention.

@render
Copy link

render bot commented Dec 14, 2021

@render
Copy link

render bot commented Dec 14, 2021

@render
Copy link

render bot commented Dec 14, 2021

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Dec 14, 2021
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's passing and no logic change 💯

@Tbaut Tbaut merged commit 6ebfb23 into dev Dec 14, 2021
@Tbaut Tbaut deleted the mnt/identifier-housekeeping-1795 branch December 14, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page object identifier standardization
2 participants