Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve credit card flow #1828

Merged
merged 7 commits into from
Dec 16, 2021
Merged

Improve credit card flow #1828

merged 7 commits into from
Dec 16, 2021

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Dec 14, 2021

closes #1825
closes #1654


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Dec 14, 2021

@render
Copy link

render bot commented Dec 14, 2021

@render
Copy link

render bot commented Dec 14, 2021

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Dec 14, 2021
@tanmoyAtb tanmoyAtb marked this pull request as draft December 14, 2021 18:34
@tanmoyAtb tanmoyAtb marked this pull request as ready for review December 14, 2021 19:31
@tanmoyAtb tanmoyAtb requested a review from Tbaut December 16, 2021 09:47
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 tested mobile view on many modals, and looks great

@Tbaut Tbaut merged commit 7831213 into dev Dec 16, 2021
@Tbaut Tbaut deleted the feat/improve-credit-card-flow-1825 branch December 16, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve credit card flow design Update Product plans page link in select plan
4 participants