Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification button height #1854

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Notification button height #1854

merged 3 commits into from
Jan 14, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1840

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jan 13, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1854.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7g4qej19n0f33b2rapg.

@render
Copy link

render bot commented Jan 13, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1854.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7g4qf319n0f33b2rb60.

@render
Copy link

render bot commented Jan 13, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1854.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7g4qfj19n0f33b2rbag.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jan 13, 2022
@tanmoyAtb tanmoyAtb requested review from FSM1, asnaith and Tbaut January 13, 2022 16:03
@tanmoyAtb tanmoyAtb changed the title Notification button heigh Notification button height Jan 13, 2022
Tbaut
Tbaut approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

asnaith
asnaith approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🙏

@Tbaut Tbaut merged commit a9216a5 into dev Jan 14, 2022
@Tbaut Tbaut deleted the fix/notification-button-height-1840 branch January 14, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Height discrepancy on notification button
3 participants
@tanmoyAtb @asnaith @Tbaut