Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ui test for checking invalid card details #1868

Merged
merged 4 commits into from
Jan 20, 2022
Merged

add ui test for checking invalid card details #1868

merged 4 commits into from
Jan 20, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Jan 19, 2022

closes #1863

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jan 19, 2022
Tbaut
Tbaut approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're testing stripe's components here rather than ours :)
But it can't hurt anyway.

@asnaith asnaith merged commit b6e0218 into mnt/change-plan-ui-tests-1857 Jan 20, 2022
@asnaith asnaith deleted the mnt/card-error-ui-tests-1863 branch January 20, 2022 18:18
@asnaith asnaith mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asnaith @Tbaut