Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline loader when paying with crypto #1893

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jan 31, 2022

When loading a crypto payment, there's a loader, then nothing for a second, then a loader again, then the info appear.
This fixes it.

LMK if you don't know what I'm talking about, I can do a video.

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jan 31, 2022

@render
Copy link

render bot commented Jan 31, 2022

@render
Copy link

render bot commented Jan 31, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jan 31, 2022
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this one. Good fix 👍

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🙂

@Tbaut Tbaut merged commit af21dcb into dev Jan 31, 2022
@Tbaut Tbaut deleted the fix/tbaut-loading-crypto branch January 31, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants