Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card subscriptions and billing page design #1906

Merged
merged 7 commits into from
Feb 3, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1885


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 1, 2022
@asnaith
Copy link
Member

asnaith commented Feb 1, 2022

Functionally everything is working well but we are displaying a "0" in the label when there is no next payment date

Screen Shot 2022-02-01 at 11 36 07 AM

Also, now that the change plan / update card buttons have been converted to links there's a difference in colour to other links displayed on the page. The news ones are blue whereas the others are white (or black in light mode).

Screen Shot 2022-02-01 at 11 46 19 AM

Lastly, the responsive layout scales down to mobile really nicely but in my opinion, can look a bit odd on a large resolution. Especially the storage space element. This is more of a design thing though so perhaps best to defer to whatever @serenaho deems is best.

Screen Shot 2022-02-01 at 11 35 16 AM

Screen Shot 2022-02-01 at 11 39 26 AM

@serenaho
Copy link
Collaborator

serenaho commented Feb 1, 2022

Thanks @asnaith for the review!

Also, now that the change plan / update card buttons have been converted to links there's a difference in colour to other links displayed on the page. The news ones are blue whereas the others are white (or black in light mode).

In regards to the link colors, I intentionally made the invoicing section a different colour as "Change Plan" and "Add Card" are two CTAs that are more active action items versus something more passive like viewing past invoices. The other key difference was that the View Invoices link led to a new page but I can see how this might be seen as inconsistent. I could definitely drop this in the Slack and see what opinions might be!

Lastly, the responsive layout scales down to mobile really nicely but in my opinion, can look a bit odd on a large resolution. Especially the storage space element.

For this, I can imagine that a good fix would be to keep it consistent with how we currently keep the inner content length maxed out at a certain size no matter how big the container gets like in the Security tab:

image

@serenaho
Copy link
Collaborator

serenaho commented Feb 1, 2022

One other small thing is that the No Invoice Found message is currently in the middle of the page which is a bit inconsistent with the rest (not sure if it's just temporarily there!). If we could left-align it in smaller text just like the current "No card" text that would work great.

image

@serenaho
Copy link
Collaborator

serenaho commented Feb 1, 2022

Okay I took a look and this is the original design I had on Figma. For some reason earlier it didn’t register in my mind that the View PDF link was also originally blue but here’s my rationale for this version:

  • The ‘All invoices’ link is a color that’s not as eye-catching because it’s a more passive type of CTA compared to the other ones
  • It’s also the only one that opens to a new page
  • The download pdf button remains blue since it’s a more active action

image

@tanmoyAtb
Copy link
Contributor Author

Thanks for all the feedbacks guys.

I've made the following updates.

  • Handled the 0 in place of next payment
  • Payment link colors according to suggestions from @serenaho
  • No invoice found line alignment
  • Max width for wider screens.

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes are looking great 🚀

@serenaho
Copy link
Collaborator

serenaho commented Feb 2, 2022

Looks awesome, thanks Tanmoy & Thibaut!

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 3, 2022

What do you think about making the max width even smaller, like 750px. On a big screen the distance between the "next payment" and the actual date is too large IMHO
image

Would look like this, which is still too far for me, but a little better. I'll bring that to our design meeting and we can create another issue to fix this better.
image

Otherwise looks great, thank you so much

@tanmoyAtb
Copy link
Contributor Author

What do you think about making the max width even smaller, like 750px. On a big screen the distance between the "next payment" and the actual date is too large IMHO image

Would look like this, which is still too far for me, but a little better. I'll bring that to our design meeting and we can create another issue to fix this better. image

Otherwise looks great, thank you so much

Fully agreed. If this comes up in the design meeting, consider all the 3 tabs and lets come up with a consistent design for all the settings.

@tanmoyAtb tanmoyAtb enabled auto-merge (squash) February 3, 2022 12:37
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's tackle this later, it's simple enough

@tanmoyAtb tanmoyAtb merged commit 872cd2f into dev Feb 3, 2022
@tanmoyAtb tanmoyAtb deleted the mnt/card-details-design-1885 branch February 3, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display additional subscription and card details
5 participants