-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card subscriptions and billing page design #1906
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1906.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7so1fnho1kg646ol2j0. |
Your Render PR Server URL is https://storage-ui-stage-pr-1906.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7so1gnho1kg646ol34g. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1906.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7so1hfho1kg646ol3h0. |
Functionally everything is working well but we are displaying a "0" in the label when there is no next payment date Also, now that the change plan / update card buttons have been converted to links there's a difference in colour to other links displayed on the page. The news ones are blue whereas the others are white (or black in light mode). Lastly, the responsive layout scales down to mobile really nicely but in my opinion, can look a bit odd on a large resolution. Especially the storage space element. This is more of a design thing though so perhaps best to defer to whatever @serenaho deems is best. |
Thanks @asnaith for the review!
In regards to the link colors, I intentionally made the invoicing section a different colour as "Change Plan" and "Add Card" are two CTAs that are more active action items versus something more passive like viewing past invoices. The other key difference was that the View Invoices link led to a new page but I can see how this might be seen as inconsistent. I could definitely drop this in the Slack and see what opinions might be!
For this, I can imagine that a good fix would be to keep it consistent with how we currently keep the inner content length maxed out at a certain size no matter how big the container gets like in the Security tab: |
Okay I took a look and this is the original design I had on Figma. For some reason earlier it didn’t register in my mind that the View PDF link was also originally blue but here’s my rationale for this version:
|
…details-design-1885
Thanks for all the feedbacks guys. I've made the following updates.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes are looking great 🚀
Looks awesome, thanks Tanmoy & Thibaut! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let's tackle this later, it's simple enough
closes #1885
Submission checklist:
Layout
Theme