Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store monthly/yearly state higher in the arch tree and remember it #1915

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 3, 2022

closes #1905

monthly.mp4

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@Tbaut Tbaut requested review from asnaith, tanmoyAtb and FSM1 February 3, 2022 16:27
@render
Copy link

render bot commented Feb 3, 2022

@render
Copy link

render bot commented Feb 3, 2022

@render
Copy link

render bot commented Feb 3, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Feb 3, 2022
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to go !

@Tbaut Tbaut merged commit 2c5948c into dev Feb 4, 2022
@Tbaut Tbaut deleted the fix/toggle-1905 branch February 4, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve toggle state so that it persists between modal transitions
3 participants