Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning before proceeding to crypto payment #1917

Merged
merged 7 commits into from
Feb 5, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 4, 2022

closes #1911


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 4, 2022

@render
Copy link

render bot commented Feb 4, 2022

@render
Copy link

render bot commented Feb 4, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 4, 2022
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design looks good.

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree that the copy change per Tanmoy's comment would be better

@Tbaut Tbaut enabled auto-merge (squash) February 4, 2022 23:52
@Tbaut Tbaut merged commit 012f0ca into dev Feb 5, 2022
@Tbaut Tbaut deleted the mnt/warning-crypto-60min-1911 branch February 5, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some information regarding the crypto time lock
4 participants