Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui test for downgrading subscription plan #1919

Merged
merged 12 commits into from
Feb 8, 2022
Merged

Add ui test for downgrading subscription plan #1919

merged 12 commits into from
Feb 8, 2022
+173 −14

Conversation

asnaith
Copy link
Contributor

@asnaith asnaith commented Feb 7, 2022

closes #1918

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 7, 2022
@asnaith asnaith requested review from tanmoyAtb, FSM1 and Tbaut February 7, 2022 03:16
@asnaith asnaith added the Status: Review Needed 👀 Added to PRs when they need more review label Feb 7, 2022
@asnaith asnaith changed the base branch from mnt/plan-toggle-ui-tests-1898 to dev February 7, 2022 05:55
@asnaith asnaith changed the base branch from dev to mnt/plan-toggle-ui-tests-1898 February 7, 2022 05:55
Base automatically changed from mnt/plan-toggle-ui-tests-1898 to dev February 7, 2022 13:29
@render
Copy link

render bot commented Feb 7, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1919.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c80huq4objd9od7vkra0.

@render
Copy link

render bot commented Feb 7, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1919.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c80huqsobjd9od7vkreg.

@render
Copy link

render bot commented Feb 7, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1919.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c80hurcobjd9od7vks00.

Tbaut
Tbaut reviewed Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit to avoid duplicating code

@Tbaut Tbaut self-requested a review February 8, 2022 10:59
Tbaut
Tbaut approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Tbaut Tbaut merged commit 8dc2f00 into dev Feb 8, 2022
@Tbaut Tbaut deleted the mnt/subscription-downgrade-ui-test-1918 branch February 8, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1

@Tbaut Tbaut

@tanmoyAtb tanmoyAtb

Assignees

@asnaith asnaith

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui test for subscription plan downgrade
3 participants
@asnaith @FSM1 @Tbaut