Cross position in subscription modal fix #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-1936.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c837f1s41ls7qdkvctog. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-1936.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c837f2c41ls7qdkvctt0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1936.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c837f3441ls7qdkvcuag. |
github-actions
bot
added
the
Type: Bug Fix
Tbaut
reviewed
Feb 11, 2022
|
This change does mess with the padding that the modal usually has: After: |
…-button-in-subscription-plan-modal
|
Looks good 🔥 I will re-test when crypto payment modal gets the same fix applied |
|
All right, this should be good now. 👍 |
asnaith
approved these changes
Feb 11, 2022
|
I'll let @FSM1 confirm it's looking good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a small bug on the subscription modal with some screen sizes. Here's a screenshot.
This PR fixes the problem.