Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings back icon in mobile view #1946

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Settings back icon in mobile view #1946

merged 4 commits into from
Feb 15, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1913


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 14, 2022

@render
Copy link

render bot commented Feb 14, 2022

@render
Copy link

render bot commented Feb 14, 2022

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Feb 14, 2022
@tanmoyAtb tanmoyAtb marked this pull request as ready for review February 14, 2022 18:58
@asnaith
Copy link
Member

asnaith commented Feb 14, 2022

Compared to Serena's mock on the issue ticket, it looks like the left arrow is only supposed to be shown when a tab has been opened and when on the main settings screen the header should be displayed as normal.

At the moment the left arrow and smaller text is shown on the main settings screen too.

Screen Shot 2022-02-14 at 12 27 36 PM

Also, could we make the left arrow itself a tappable target? At the moment it's only the text.

@tanmoyAtb
Copy link
Contributor Author

Compared to Serena's mock on the issue ticket, it looks like the left arrow is only supposed to be shown when a tab has been opened and when on the main settings screen the header should be displayed as normal.

At the moment the left arrow and smaller text is shown on the main settings screen too.

Screen Shot 2022-02-14 at 12 27 36 PM

Also, could we make the left arrow itself a tappable target? At the moment it's only the text.

Thanks for the pointers @asnaith. It looks better with the feedbacks in.

@tanmoyAtb tanmoyAtb added the Status: Review Needed 👀 Added to PRs when they need more review label Feb 15, 2022
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanmoyAtb Looking great with the latest changes 🚀

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Tbaut Tbaut enabled auto-merge (squash) February 15, 2022 21:25
@Tbaut Tbaut merged commit 3140224 into dev Feb 15, 2022
@Tbaut Tbaut deleted the feat/settings-back-1913 branch February 15, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking enabled on Settings header area
3 participants