-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings back icon in mobile view #1946
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-1946.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c85abm7d17cc8bda22c0. |
Your Render PR Server URL is https://storage-ui-stage-pr-1946.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c85abmvd17cc8bda22gg. |
Your Render PR Server URL is https://files-ui-stage-pr-1946.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c85abnfd17cc8bda22t0. |
Compared to Serena's mock on the issue ticket, it looks like the left arrow is only supposed to be shown when a tab has been opened and when on the main settings screen the header should be displayed as normal. At the moment the left arrow and smaller text is shown on the main settings screen too. Also, could we make the left arrow itself a tappable target? At the moment it's only the text. |
Thanks for the pointers @asnaith. It looks better with the feedbacks in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanmoyAtb Looking great with the latest changes 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
closes #1913
Submission checklist:
Layout
Theme