Refactor shared folder creation

[Tbaut]

closes #1943

---

Submission checklist:

Layout

• Change looks good in the desktop web ui
• Change looks good in the mobile web ui

Theme

• Components / elements inspected in light mode
• Components / elements inspected in dark mode

[render]

Your Render PR Server URL is https://chainsafe-components-stage-pr-1953.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c86jhhj19n0dr8ao5f00.

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-1953.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c86jhi319n0dr8ao5f4g.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-1953.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c86jhir19n0dr8ao5fh0.

[Tbaut]

The test should now pass, note @asnaith that due to my refactoring, the tests aren't as nice as they used to be. For instance to create a shared folder (the helper function that is only used once), I do the following:

• navigate to the shared folder
• click on the create button
• type in a name
• click on "Create"
• click on "Cancel" on the next screen, because I don't care about adding any user. I find this step somewhat inelegant.

[asnaith]

@Tbaut the new modals are working really well and they're a big ux improvement especially on mobile 🚀

The test edits look great too, I pushed a few tiny commits for minor things but that's all. As for the extra step, I don't think it's too inelegant - it's 1 of only 2 valid paths that the user can take at that point of the share flow 🙂.

It did make me realize that we are lacking automated test coverage for adding by name / wallet / address / ens though. I'll create a ticket for that!

[FSM1]

working really nicely 🎉

[FSM1]

@Tbaut the new modals are working really well and they're a big ux improvement especially on mobile 🚀

The test edits look great too, I pushed a few tiny commits for minor things but that's all. As for the extra step, I don't think it's too inelegant - it's 1 of only 2 valid paths that the user can take at that point of the share flow 🙂.

It did make me realize that we are lacking automated test coverage for adding by name / wallet / address / ens though. I'll create a ticket for that!

hahah Ryan's staging user is going to have ALL the things shared with him 😂