Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align new shared folder design with other modals #1955

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Align new shared folder design with other modals #1955

merged 4 commits into from
Feb 21, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 17, 2022

closes #1941

image

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1955.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8757146fj33cc3207kg.

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1955.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c87571k6fj33cc3207pg.

@render
Copy link

render bot commented Feb 17, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1955.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8757246fj33cc320890.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Feb 17, 2022
@Tbaut Tbaut changed the title align right Align new shared folder design with other modals Feb 17, 2022
@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Feb 17, 2022
asnaith
asnaith approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice improvement, especially for our mobile users 👍

@Tbaut Tbaut enabled auto-merge (squash) February 21, 2022 11:34
@Tbaut Tbaut merged commit 6358a96 into dev Feb 21, 2022
@Tbaut Tbaut deleted the fix/tbaut-1941 branch February 21, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith asnaith approved these changes

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New shared folder modal design isn't aligned with the others
5 participants
@Tbaut @asnaith @tanmoyAtb @FSM1 @actions-user