Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui test for downgrade plan selection #1958

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Add ui test for downgrade plan selection #1958

merged 4 commits into from
Feb 21, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Feb 18, 2022 •
edited
Loading

closes #1949

  • A check to ensure that a user can't choose a plan if their storage quota is above that plan's allowance

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Feb 18, 2022
@render
Copy link

render bot commented Feb 18, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1958.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c87jhqvh8vl50qmk858g.

@render
Copy link

render bot commented Feb 18, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1958.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c87jhrfh8vl50qmk85d0.

@render
Copy link

render bot commented Feb 18, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1958.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c87jhrvh8vl50qmk85pg.

Tbaut
Tbaut approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good beside my suggestion :)

@asnaith @Tbaut
Remove unnecessary stub as per PR feedback
9473b36 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@Tbaut Tbaut merged commit a9f9079 into dev Feb 21, 2022
@Tbaut Tbaut deleted the mnt/add-ui-test-plan-selection-1949 branch February 21, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui test coverage for plan selection availability
3 participants
@asnaith @FSM1 @Tbaut