Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix login screen and nav bar #2005

Merged
merged 5 commits into from
Mar 14, 2022
Merged

[Storage] Fix login screen and nav bar #2005

merged 5 commits into from
Mar 14, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Mar 4, 2022

One part of #1968

resizing.mp4

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

@Tbaut Tbaut requested review from asnaith, tanmoyAtb and FSM1 March 4, 2022 15:56
@render
Copy link

render bot commented Mar 4, 2022

@render
Copy link

render bot commented Mar 4, 2022

@render
Copy link

render bot commented Mar 4, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Mar 4, 2022
@asnaith
Copy link
Member

asnaith commented Mar 7, 2022

The login screen is good but I'm seeing an issue with a scroll bar around the side-menu navigation after logging in

Screen Shot 2022-03-07 at 10 36 40 AM

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good after the latest changes 👍

Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@Tbaut
Copy link
Collaborator Author

Tbaut commented Mar 14, 2022

Thanks Mike for the fix 🙏 Firefox didn't show this :)

@Tbaut Tbaut merged commit 06d1db5 into dev Mar 14, 2022
@Tbaut Tbaut deleted the fix/tbaut-shrinkable branch March 14, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants