Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications context, and push for Billing #2017

Merged
merged 12 commits into from
Mar 16, 2022
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Mar 15, 2022

closes #1992

@Tbaut Tbaut requested review from asnaith, tanmoyAtb and FSM1 March 15, 2022 16:48
@render
Copy link

render bot commented Mar 15, 2022

@render
Copy link

render bot commented Mar 15, 2022

@render
Copy link

render bot commented Mar 15, 2022

@Tbaut Tbaut enabled auto-merge (squash) March 15, 2022 19:47
Copy link
Contributor

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for expiring card and unpaid crypto invoice notifications (I don't have an easy way to invoke the restricted account notification)

@Tbaut Tbaut merged commit c8f8bf3 into dev Mar 16, 2022
@Tbaut Tbaut deleted the fix/tbaut-notifications-1992 branch March 16, 2022 06:11
@Tbaut
Copy link
Collaborator Author

Tbaut commented Mar 16, 2022

the restricted one isn't implemented yet, this requires some more fiddling left for another issue (#2020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notifications to Storage
4 participants