Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plan sorting #2021

Merged
merged 3 commits into from
Mar 17, 2022
Merged

fix plan sorting #2021

merged 3 commits into from
Mar 17, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Mar 16, 2022

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

Billing

  • Change applied to both files-ui and storage-ui

@render
Copy link

render bot commented Mar 16, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2021.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8p325nd17c4krtoe900.

@render
Copy link

render bot commented Mar 16, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2021.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8p326vd17c4krtoea8g.

@render
Copy link

render bot commented Mar 16, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2021.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8p3287d17c4krtoeam0.

asnaith
asnaith approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in Files and Storage 👍

@FSM1 FSM1 enabled auto-merge (squash) March 16, 2022 23:09
Tbaut
Tbaut approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Render failed to deploy, manually relaunched it.

@FSM1 FSM1 merged commit 36a76ac into dev Mar 17, 2022
@FSM1 FSM1 deleted the feat/plan-sorting branch March 17, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@asnaith asnaith asnaith approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FSM1 @asnaith @Tbaut