Add ui tests for copying / moving to share folders #2032
Conversation
asnaith
added
the
Type: Maintenance
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-2032.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8sip2jvog4pa8qkqvf0. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-2032.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8sip3jvog4pa8qkqvjg. |
|
Your Render PR Server URL is https://files-ui-stage-pr-2032.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8sip4jvog4pa8qkr010. |
| cy.get("@fileName").then(($fileName) => { | ||
| sharedPage.fileItemName().contains(`${$fileName}`).should("be.visible") |
There was a problem hiding this comment.
A little more elegant IMHO. Feel free to ignore if you feel it's too complex
| cy.get("@fileName").then(($fileName) => { | |
| sharedPage.fileItemName().contains(`${$fileName}`).should("be.visible") | |
| cy.get<string>("@fileName").then((fileName) => { | |
| sharedPage.fileItemName().contains(fileName).should("be.visible") |
There was a problem hiding this comment.
@Tbaut I like it. Thanks for the suggestion, I'm always thankful and appreciative of these tips to write cleaner code.
I've gone ahead and used it as suggested and I also updated all the other places where we are doing similar things. It looks and reads better 👍
…files-ui into mnt/add-share-copy-tests-2029
closes #2029
adds coverage for the 4 scenarios when copying / moving files to new / existing shares and preserving / deleting the original