Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has mnemonic share check #2041

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Has mnemonic share check #2041

merged 2 commits into from
Mar 24, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Mar 24, 2022

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

Billing

  • Change applied to both files-ui and storage-ui

@FSM1 FSM1 requested review from tanmoyAtb and Tbaut March 24, 2022 13:39
@FSM1 FSM1 self-assigned this Mar 24, 2022
@FSM1 FSM1 added Status: Review Needed 👀 Added to PRs when they need more review Product: Files labels Mar 24, 2022
@FSM1 FSM1 enabled auto-merge March 24, 2022 13:39
@Tbaut
Copy link
Collaborator

Tbaut commented Mar 24, 2022

I'll close and open again to let the render etc kick-in (maybe?)

@Tbaut Tbaut closed this Mar 24, 2022
auto-merge was automatically disabled March 24, 2022 14:55

Pull request was closed

@Tbaut Tbaut reopened this Mar 24, 2022
@render
Copy link

render bot commented Mar 24, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2041.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8u8cr0ivq0e0tbqi510.

@render
Copy link

render bot commented Mar 24, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2041.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8u8cs0ivq0e0tbqi5eg.

@render
Copy link

render bot commented Mar 24, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2041.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8u8ctgivq0e0tbqi5j0.

Tbaut
Tbaut approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well!

@FSM1 FSM1 enabled auto-merge March 24, 2022 15:34
tanmoyAtb
tanmoyAtb approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, working great 👍

@FSM1 FSM1 merged commit f4b86da into dev Mar 24, 2022
@FSM1 FSM1 deleted the fix/has-mnemonic-share-check branch March 24, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

Assignees

@FSM1 FSM1

Labels
Product: Files Status: Review Needed 👀 Added to PRs when they need more review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FSM1 @Tbaut @tanmoyAtb