Allow search pin by name and cid

[Tbaut]

closes #2024

search.mp4

[render]

Your Render PR Server URL is https://chainsafe-components-stage-pr-2046.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8utsp46fj3241sfm6ng.

[render]

Your Render PR Server URL is https://storage-ui-stage-pr-2046.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8utsqc6fj3241sfm6s0.

[render]

Your Render PR Server URL is https://files-ui-stage-pr-2046.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8utsrc6fj3241sfm7ag.

[Tbaut]

added a small fix as we go, to avoid an overlap with the search icon (not visible in the video above)

[asnaith]

Looks great in the video, will check it out once the api is ready 😊

[Tbaut]

Hey all, this has been updated, feel free to review

[asnaith]

This is working great. I just found two small issues

• The search input does not accept a space character so you'd never actually be able to search for "cute cat" 😿

• The search filter stays applied when you navigate away (but the search input is cleared). This could be confusing if the last search yielded no results (see video).

Screen.Recording.2022-03-30.at.3.40.47.PM.mov

[Tbaut]

Thanks Andrew for the laser eyes, it's fixed now

[tanmoyAtb]

Thanks Andrew for the laser eyes, it's fixed now

Just checked that the "name" field in Add pin also doesn't allow spaces in the name.

[tanmoyAtb]

Looks good,

Just found the space issue in the ADD PIN modal, the current implementation looks great.

[asnaith]

Thanks Andrew for the laser eyes, it's fixed now

Just checked that the "name" field in Add pin also doesn't allow spaces in the name.

@tanmoyAtb We have that fixed in another branch :) #2048

[Tbaut]

ah that's where I have it. Well I fixed it here as well 21232f7