Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for creation of CS FS Storage buckets #2057

Merged
merged 10 commits into from
Apr 1, 2022
Merged

Allow for creation of CS FS Storage buckets #2057

merged 10 commits into from
Apr 1, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Mar 30, 2022 •
edited
Loading

closes #2047
closes #2055
closes #2064

Submission checklist:

Layout

  • Change looks good in the desktop web ui

Theme

  • Components / elements inspected in light mode

@render
Copy link

render bot commented Mar 30, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2057.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c925g5319n0ccs83jdgg.

@FSM1 FSM1 requested a review from tanmoyAtb March 30, 2022 13:16
@render
Copy link

render bot commented Mar 30, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2057.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c925g6b19n0ccs83jdl0.

@FSM1 FSM1 requested a review from Tbaut March 30, 2022 13:16
@render
Copy link

render bot commented Mar 30, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2057.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c925g7j19n0ccs83je6g.

@FSM1 FSM1 requested a review from asnaith March 30, 2022 13:16
@FSM1 FSM1 self-assigned this Mar 30, 2022
@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Mar 30, 2022
@FSM1 FSM1 added Status: Review Needed 👀 Added to PRs when they need more review and removed Type: Feature Added to PRs to identify that the change is a new feature. labels Mar 30, 2022
@asnaith
Copy link
Member

asnaith commented Mar 30, 2022 •
edited
Loading

Looks great 🚀

Screen Shot 2022-03-30 at 4 30 20 PM

@asnaith
Copy link
Member

asnaith commented Mar 30, 2022 •
edited
Loading

Feedback (for another PR): Perhaps we should add a column for "Type" on the buckets page, make it easier for the end-user to reference later. What do you think?

Update: created an issue for it #2064

tanmoyAtb
tanmoyAtb approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great !

@Tbaut Tbaut enabled auto-merge (squash) April 1, 2022 09:58
@Tbaut Tbaut merged commit fe1ff05 into dev Apr 1, 2022
@Tbaut Tbaut deleted the feat/cs-fs-storage-buckets-2047 branch April 1, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith asnaith approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review
Projects
None yet
Milestone
No milestone
5 participants
@FSM1 @asnaith @tanmoyAtb @Tbaut @actions-user