Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ui tests for cid searching #2073

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Add new ui tests for cid searching #2073

merged 1 commit into from
Apr 5, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Apr 4, 2022

closes #2060

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Apr 4, 2022
@asnaith asnaith requested review from tanmoyAtb, FSM1 and Tbaut April 4, 2022 23:27
@render
Copy link

render bot commented Apr 4, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2073.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c95ntk397ej1347kif0g.

@render
Copy link

render bot commented Apr 4, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2073.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c95ntlj97ej1347kif5g.

@render
Copy link

render bot commented Apr 4, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2073.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c95ntn397ej1347kifn0.

@asnaith asnaith added the Status: Review Needed 👀 Added to PRs when they need more review label Apr 5, 2022
tanmoyAtb
tanmoyAtb approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! 👍

@Tbaut Tbaut enabled auto-merge (squash) April 5, 2022 16:32
Tbaut
Tbaut approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Tbaut Tbaut merged commit 9e7b587 into dev Apr 5, 2022
@Tbaut Tbaut deleted the mnt/add-cid-search-tests-2060 branch April 5, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new ui test coverage for CID search
3 participants
@asnaith @tanmoyAtb @Tbaut