Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel any action and remove any toast on logout #2075

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Cancel any action and remove any toast on logout #2075

merged 4 commits into from
Apr 6, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Apr 6, 2022

closes #2062

notif.mp4

@Tbaut Tbaut requested review from asnaith, tanmoyAtb and FSM1 April 6, 2022 13:27
@render
Copy link

render bot commented Apr 6, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2075.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c96pacr97ej4gakcj7dg.

@render
Copy link

render bot commented Apr 6, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2075.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c96padr97ej4gakcj7i0.

@render
Copy link

render bot commented Apr 6, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2075.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c96paer97ej4gakcj83g.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Apr 6, 2022
@asnaith
Copy link
Member

asnaith commented Apr 6, 2022 •
edited
Loading

Working well 👍

During testing, I realized on mobile that it's not possible to sign-out without canceling the upload process first because the element is covered. Personally, I think this is ok as-is but wanted to mention it in case anyone thinks differently about it (we can create a new issue if there's suggestions for an improvement here).

Screen Shot 2022-04-06 at 10 02 29 AM

tanmoyAtb
tanmoyAtb approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really smooth implementation 👍

@tanmoyAtb tanmoyAtb merged commit 5b84894 into dev Apr 6, 2022
@tanmoyAtb tanmoyAtb deleted the fix/tbaut-clear-notif-2062 branch April 6, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith asnaith approved these changes

Assignees
No one assigned
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear Upload/Download progress toasts on logout
4 participants
@Tbaut @asnaith @tanmoyAtb @FSM1