Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shared folder update button to close the modal #2080

Merged
merged 5 commits into from
Apr 11, 2022
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Apr 7, 2022

closes #2068

When only a link was generated, the Update button will be enabled but will just close the modal.

@Tbaut Tbaut requested review from asnaith, tanmoyAtb and FSM1 April 7, 2022 09:00
@render
Copy link

render bot commented Apr 7, 2022

@render
Copy link

render bot commented Apr 7, 2022

@render
Copy link

render bot commented Apr 7, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Apr 7, 2022
@Tbaut Tbaut enabled auto-merge (squash) April 7, 2022 09:58
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, made a couple small changes, mainly ensuring that setTouchedLinksList is called when removing a link.

@Tbaut Tbaut merged commit 2b7b71c into dev Apr 11, 2022
@Tbaut Tbaut deleted the fix/tbaut-2068 branch April 11, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing disabled "Update" button when only a link got added/changed to a shared bucket
3 participants