Fix double slash when uploading a file #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-2106.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9f98oj19n037fqqlfjg. |
|
Your Render PR Server URL is https://files-ui-stage-pr-2106.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9f98pb19n037fqqlfo0. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-2106.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9f98qb19n037fqqlg9g. |
github-actions
bot
added
the
Type: Bug Fix
FSM1
approved these changes
Apr 19, 2022
tanmoyAtb
approved these changes
Apr 19, 2022
|
@Tbaut nice work on pinpointing the true cause of this! Great to get it fixed 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel we've seen this issue before, reported by Andrew. As I was debugging something else, I found out why it happens.
How to reproduce:
//some dir/some-filewith a double slashThis should fix it.
@asnaith although I think this is a pretty safe change IMHO, this helper function is used a lot, and it is potentially breaking things. I've spent quite some time to test things, it's used in the preview overview, move files, create directories etc..