Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] Add landing page tests #2115

Merged
merged 8 commits into from
May 4, 2022
Merged

[Files] Add landing page tests #2115

merged 8 commits into from
May 4, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2114

@juans-chainsafe juans-chainsafe linked an issue May 3, 2022 that may be closed by this pull request
Add new ui test coverage for landing page in Files #2114
Closed
@render
Copy link

render bot commented May 3, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2115.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9omdq7s437ifb3f03og.

@render
Copy link

render bot commented May 3, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2115.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9omdr7s437ifb3f03t0.

@render
Copy link

render bot commented May 3, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2115.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c9omds7s437ifb3f04eg.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label May 3, 2022
asnaith
asnaith approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, 2nd week and already adding more test coverage 🙌

These look good, now these links can't break without us knowing about it :)

tanmoyAtb
tanmoyAtb approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯

@juans-chainsafe juans-chainsafe merged commit 82741b1 into dev May 4, 2022
@juans-chainsafe juans-chainsafe deleted the mnt/add-landing-page-tests-2114 branch May 4, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith asnaith approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new ui test coverage for landing page in Files
4 participants
@juans-chainsafe @asnaith @tanmoyAtb @FSM1