Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeout to improve storage test reliability #2129

Merged
merged 3 commits into from
May 16, 2022

Conversation

asnaith
Copy link
Contributor

@asnaith asnaith commented May 12, 2022

Just a quick one liner -

I realized I was overzealous in another PR last week when I removed some timeouts. Re-adding this one as it caused a reliability issue with storage tests in CI (where network speed can be slower).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label May 12, 2022
@render
Copy link

render bot commented May 12, 2022

@render
Copy link

render bot commented May 12, 2022

@asnaith asnaith enabled auto-merge (squash) May 12, 2022 17:14
@render
Copy link

render bot commented May 12, 2022

@asnaith asnaith disabled auto-merge May 12, 2022 18:57
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the tests in Storage were fixed by this change. Apparently the lingui/lint errors are not from this change

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it can't hurt

@Tbaut Tbaut enabled auto-merge (squash) May 13, 2022 18:07
@Tbaut Tbaut merged commit 2128de0 into dev May 16, 2022
@Tbaut Tbaut deleted the mnt/extend-header-element-timeout branch May 16, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants