Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload notification #2138

Merged
merged 12 commits into from
May 19, 2022
Merged

Upload notification #2138

merged 12 commits into from
May 19, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented May 19, 2022

closes #2097

@render
Copy link

render bot commented May 19, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2138.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca2oktkgqg4fg472dik0.

@render
Copy link

render bot commented May 19, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2138.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca2okukgqg4fg472diog.

@render
Copy link

render bot commented May 19, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2138.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca2okvkgqg4fg472dja0.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label May 19, 2022
@FSM1 FSM1 requested review from Tbaut and tanmoyAtb May 19, 2022 00:08
Tbaut
Tbaut approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a beautiful refactor. Agreed that the for .. ofhere is better than the .reduce with some weird await :)

Working well, I tested with deeply nested directories without issue.

packages/files-ui/src/Contexts/FilesContext.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Contexts/FilesContext.tsx Outdated Show resolved Hide resolved
juans-chainsafe
juans-chainsafe approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected in all browsers, amazing job!

tanmoyAtb
tanmoyAtb approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and smooth !

@FSM1 FSM1 merged commit bde12d0 into dev May 19, 2022
@FSM1 FSM1 deleted the fix/upload-notification-2097 branch May 19, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees
No one assigned
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
6 participants
@FSM1 @tanmoyAtb @Tbaut @juans-chainsafe @asnaith @actions-user